fix Paraglide Start scaffold integration - #503
Open
samuelstroschein wants to merge 1 commit into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe Paraglide add-on now generates localized TanStack Router rewrites and a server entry that applies request-scoped middleware. An integration test verifies the generated files, and a patch changeset documents the update. ChangesParaglide integration
Estimated code review effort: 3 (Moderate) | ~20 minutes Mergeability Score: ⚪ Minimal · up to This PR adds the missing locale URL rewrites and server middleware to generated Paraglide TanStack Start projects; no actionable merge-blocking risk remains after the reported validation. Sequence Diagram(s)sequenceDiagram
participant Request
participant GeneratedServer
participant ParaglideMiddleware
participant TanStackHandler
participant Router
Request->>GeneratedServer: fetch(req)
GeneratedServer->>ParaglideMiddleware: wrap request
ParaglideMiddleware->>TanStackHandler: invoke handler.fetch
TanStackHandler->>Router: process URL
Router->>Router: deLocalizeUrl input
Router->>Router: localizeUrl output
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
samuelstroschein
marked this pull request as ready for review
August 13, 2026 17:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
paraglideMiddlewareWhy
The Paraglide add-on generated locale-switching UI, but omitted the URL rewrite and server middleware shown in the official TanStack i18n setup. A switch to German navigated to
/de, which the router treated as an unmatched route, while SSR continued rendering the fallback locale. The resulting server/client disagreement caused not-found warnings and hydration failures on every locale switch.Related: opral/paraglide-js#739
Validation
@tanstack/create, and 7 files / 101 tests in@tanstack/clisrc/router.tsxandsrc/server.tsSummary by CodeRabbit
New Features
Tests